Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to Arrow.scala #2668

Merged
merged 1 commit into from
Dec 15, 2018
Merged

Fix broken link to Arrow.scala #2668

merged 1 commit into from
Dec 15, 2018

Conversation

DieBauer
Copy link
Contributor

As stated by #1435 (comment) the {{ site.sources }} configuration item was lost.

Already 6 occurrences exist in the docs that link directly to https://github.com/typelevel/cats/blob/master.
In all documentation, this was the only place where sources was still used, so instead of adding a custom yaml and keep the tightly coupling with Jekyll, I've replaced this one instance with another hard-coded link to master.

As stated by typelevel#1435 (comment) the `{{ site.sources }}` configuration item was lost. 

Already 6 occurrences exist in the docs that link directly to `https://github.com/typelevel/cats/blob/master`. 
In all documentation, this was the only place where `sources` was still used, so instead of adding a [custom yaml](https://47deg.github.io/sbt-microsites/docs/settings.html) and keep the tightly coupling with Jekyll, I've replaced this one instance with another hard-coded link to master.
Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov-io
Copy link

codecov-io commented Dec 15, 2018

Codecov Report

Merging #2668 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2668   +/-   ##
=======================================
  Coverage   95.12%   95.12%           
=======================================
  Files         364      364           
  Lines        6707     6707           
  Branches      301      285   -16     
=======================================
  Hits         6380     6380           
  Misses        327      327

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9707f1...73059f7. Read the comment docs.

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DieBauer!

@ceedubs ceedubs merged commit e43e436 into typelevel:master Dec 15, 2018
@kailuowang kailuowang added this to the 1.6 milestone Jan 8, 2019
@DieBauer DieBauer deleted the patch-1 branch January 15, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants